feat(performance): improve Log Processing performance #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testkube-docs-preview canceled.
|
rangoo94
force-pushed
the
dawid/feat/performance-improvements-for-log-processing
branch
from
adb693f
to
fdc56a0
Compare
vsukhin
approved these changes
Jul 9, 2024
exu
approved these changes
Jul 9, 2024
…or WatchInstrumentedPod
rangoo94
deleted the
dawid/feat/performance-improvements-for-log-processing
branch
dejanzele
added a commit
that referenced
this pull request
Jul 10, 2024
* feat: [TKC-2194] improve workflow execution telemetry (#5648) * TKC-2161: skip tls verification when saving logs if STORAGE_SKIP_VERIFY is true (#5627) * build(deps): bump anchore/sbom-action from 0.16.0 to 0.16.1 (#5649) Bumps [anchore/sbom-action](https://github.com/anchore/sbom-action) from 0.16.0 to 0.16.1. - [Release notes](https://github.com/anchore/sbom-action/releases) - [Commits](anchore/sbom-action@v0.16.0...v0.16.1) --- updated-dependencies: - dependency-name: anchore/sbom-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(performance): improve Log Processing performance (#5647) * feat(performance): buffer the logs sent from the container, to avoid sending message for each line * feat(performance): batch Test Workflow's result updates * fix(testworkflows): handle getting long container logs after the log rotation happens @see {@link https://stackoverflow.com/a/68673451} * feat(testworkflows): optimize reading timestamp from Kubernetes logs * feat(testworkflows): optimize buffering logs * feat(testworkflows): use native channel instead of heavier Channels for WatchInstrumentedPod * feat(testworkflows): increase buffer size for logs buffering --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Povilas Versockas <[email protected]> Co-authored-by: Dejan Zele Pejchev <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
The batching works as follows:
In the result, the Test Workflows with significant amount of logs are working much better - both the real-time stream is faster, as well as the result computation (so the Test Workflow is marked done almost immediately after it's finished, even when there is a lot of logs).
Checklist (choose whats happened)