fix: show "execution aborted before" only when the step was not start…

…ed already
kubeshop · Aug 5, 2024 · b162cd2 · b162cd2
1 parent c25e05d
commit b162cd2
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/pkg/testworkflows/testworkflowcontroller/watchinstrumentedpod.go b/pkg/testworkflows/testworkflowcontroller/watchinstrumentedpod.go
@@ -255,13 +255,15 @@ func WatchInstrumentedPod(parentCtx context.Context, clientSet kubernetes.Interf
 				for ref := range s.result.Steps {
 					if !s.IsFinished(ref) {
 						status := testkube.SKIPPED_TestWorkflowStepStatus
-						if s.result.Steps[ref].Status != nil && *s.result.Steps[ref].Status == testkube.ABORTED_TestWorkflowStepStatus {
+						details := "The execution was aborted before."
+						if s.result.Steps[ref].Status != nil && *s.result.Steps[ref].Status != testkube.QUEUED_TestWorkflowStepStatus {
 							status = testkube.ABORTED_TestWorkflowStepStatus
+							details = ""
 						}
 						s.FinishStep(ref, ContainerResultStep{
 							Status:     status,
 							ExitCode:   -1,
-							Details:    "The execution was aborted before.",
+							Details:    details,
 							FinishedAt: lastTs,
 						})
 					}