fix: calibrate clocks

kubeshop · Aug 13, 2024 · 5652bfd · 5652bfd
1 parent a70e92b
commit 5652bfd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 9 deletions.
diff --git a/pkg/api/v1/testkube/model_test_workflow_result_extended.go b/pkg/api/v1/testkube/model_test_workflow_result_extended.go
@@ -404,8 +404,12 @@ func (r *TestWorkflowResult) Recompute(sig []TestWorkflowSignature, scheduledAt
 		r.Status = common.Ptr(RUNNING_TestWorkflowStatus)
 	}
 
-	if r.FinishedAt.IsZero() && r.Status != nil && *r.Status == ABORTED_TestWorkflowStatus {
-		r.FinishedAt = r.LatestTimestamp()
+	// Ensure the finish time is after all other timestamps
+	if !r.FinishedAt.IsZero() || (r.Status != nil && *r.Status == ABORTED_TestWorkflowStatus) {
+		lastTs := r.LatestTimestamp()
+		if r.FinishedAt.Before(lastTs) {
+			r.FinishedAt = lastTs
+		}
 	}
 
 	// Compute the duration

diff --git a/pkg/testworkflows/testworkflowcontroller/notifier.go b/pkg/testworkflows/testworkflowcontroller/notifier.go
@@ -292,11 +292,11 @@ func (n *notifier) Output(ref string, ts time.Time, output *instructions.Instruc
 }
 
 func (n *notifier) Finish(ts time.Time) {
-	n.resultMu.Lock()
-	defer n.resultMu.Unlock()
-	if !n.result.FinishedAt.Before(ts) {
+	if ts.IsZero() {
 		return
 	}
+	n.resultMu.Lock()
+	defer n.resultMu.Unlock()
 	n.result.FinishedAt = ts
 	n.emit()
 }

diff --git a/pkg/testworkflows/testworkflowcontroller/watchinstrumentedpod.go b/pkg/testworkflows/testworkflowcontroller/watchinstrumentedpod.go
@@ -269,20 +269,27 @@ func WatchInstrumentedPod(parentCtx context.Context, clientSet kubernetes.Interf
 						Status:     testkube.ABORTED_TestWorkflowStepStatus,
 						ExitCode:   -1,
 						Details:    result.Details,
-						FinishedAt: result.FinishedAt,
+						FinishedAt: s.GetStepResult(ref).FinishedAt,
+					}
+					if status.FinishedAt.IsZero() {
+						status.FinishedAt = result.FinishedAt
 					}
 					if status.FinishedAt.IsZero() {
 						status.FinishedAt = state.FinishedAt("")
-						if status.FinishedAt.IsZero() {
-							status.FinishedAt = s.GetLastTimestamp(lastStarted)
-						}
+					}
+					if status.FinishedAt.IsZero() {
+						status.FinishedAt = s.GetLastTimestamp(lastStarted)
 					}
 
 					if len(result.Steps) > i {
 						status = result.Steps[i]
 						if status.Details == "" {
 							status.Details = result.Details
 						}
+						finishedAt := s.GetStepResult(ref).FinishedAt
+						if !finishedAt.IsZero() {
+							status.FinishedAt = finishedAt
+						}
 					}
 					s.FinishStep(ref, status)
 					if status.Status == testkube.ABORTED_TestWorkflowStepStatus {