feat: [TKC-2063] Delete testworkflow output when workflow is deleted (#…

…5509)

cmd/api-server/main.go

@@ -298,7 +298,7 @@ func main() {
 		}
 		storageClient = minioClient
 		// Pro edition only (tcl protected code)
-		testWorkflowOutputRepository = testworkflow.NewMinioOutputRepository(storageClient, cfg.LogsBucket)
+		testWorkflowOutputRepository = testworkflow.NewMinioOutputRepository(storageClient, db.Collection(testworkflow.CollectionName), cfg.LogsBucket)
 		artifactStorage = minio.NewMinIOArtifactClient(storageClient)
 		// init storage
 		isMinioStorage := cfg.LogsStorage == "minio"

pkg/tcl/apitcl/v1/testworkflows.go

@@ -69,6 +69,10 @@ func (s *apiTCL) DeleteTestWorkflowHandler() fiber.Handler {
 		}
 		skipExecutions := c.Query("skipDeleteExecutions", "")
 		if skipExecutions != "true" {
+			err = s.TestWorkflowOutput.DeleteOutputByTestWorkflow(context.Background(), name)
+			if err != nil {
+				return s.ClientError(c, "deleting executions output", err)
+			}
 			err = s.TestWorkflowResults.DeleteByTestWorkflow(context.Background(), name)
 			if err != nil {
 				return s.ClientError(c, "deleting executions", err)

pkg/tcl/cloudtcl/data/testworkflow/execution_models.go

@@ -114,6 +114,13 @@ type ExecutionDeleteByWorkflowRequest struct {
 type ExecutionDeleteByWorkflowResponse struct {
 }
 
+type ExecutionDeleteOutputByWorkflowRequest struct {
+	WorkflowName string `json:"workflowName"`
+}
+
+type ExecutionDeleteOutputByWorkflowResponse struct {
+}
+
 type ExecutionDeleteAllRequest struct {
 }
 

pkg/tcl/cloudtcl/data/testworkflow/output.go

@@ -105,3 +105,9 @@ func (r *CloudOutputRepository) HasLog(ctx context.Context, id, workflowName str
 	}
 	return pass(r.executor, ctx, req, process)
 }
+
+// DeleteByTestWorkflow deletes execution results by workflow
+func (r *CloudOutputRepository) DeleteOutputByTestWorkflow(ctx context.Context, workflowName string) (err error) {
+	req := ExecutionDeleteOutputByWorkflowRequest{WorkflowName: workflowName}
+	return passNoContent(r.executor, ctx, req)
+}

pkg/tcl/repositorytcl/testworkflow/interface.go

@@ -86,4 +86,7 @@ type OutputRepository interface {
 	ReadLog(ctx context.Context, id, workflowName string) (io.Reader, error)
 	// HasLog checks if there is an output in Minio
 	HasLog(ctx context.Context, id, workflowName string) (bool, error)
+
+	// DeleteOutputByTestWorkflow deletes execution output by test workflow
+	DeleteOutputByTestWorkflow(ctx context.Context, testWorkflowName string) error
 }

pkg/tcl/repositorytcl/testworkflow/minio_output_repository.go

@@ -13,24 +13,30 @@ import (
 	"io"
 	"time"
 
+	"github.com/kubeshop/testkube/pkg/api/v1/testkube"
 	"github.com/kubeshop/testkube/pkg/log"
 	"github.com/kubeshop/testkube/pkg/storage"
+
+	"go.mongodb.org/mongo-driver/bson"
+	"go.mongodb.org/mongo-driver/mongo"
 )
 
 var _ OutputRepository = (*MinioRepository)(nil)
 
 const bucketFolder = "testworkflows"
 
 type MinioRepository struct {
-	storage storage.Client
-	bucket  string
+	storage             storage.Client
+	executionCollection *mongo.Collection
+	bucket              string
 }
 
-func NewMinioOutputRepository(storageClient storage.Client, bucket string) *MinioRepository {
+func NewMinioOutputRepository(storageClient storage.Client, executionCollection *mongo.Collection, bucket string) *MinioRepository {
 	log.DefaultLogger.Debugw("creating minio workflow output repository", "bucket", bucket)
 	return &MinioRepository{
-		storage: storageClient,
-		bucket:  bucket,
+		storage:             storageClient,
+		executionCollection: executionCollection,
+		bucket:              bucket,
 	}
 }
 
@@ -66,3 +72,30 @@ func (m *MinioRepository) HasLog(ctx context.Context, id, workflowName string) (
 	}
 	return true, nil
 }
+
+func (m *MinioRepository) DeleteOutputByTestWorkflow(ctx context.Context, testWorkflowName string) error {
+	log.DefaultLogger.Debugw("deleting output by testWorkflowName", "testWorkflowName", testWorkflowName)
+	var executions []testkube.TestWorkflowExecution
+	//TODO
+	cursor, err := m.executionCollection.Find(ctx, bson.M{"testworkflow.name": testWorkflowName})
+	if err != nil {
+		return err
+	}
+	err = cursor.All(ctx, &executions)
+	if err != nil {
+		return err
+	}
+	for _, execution := range executions {
+		log.DefaultLogger.Debugw("deleting output for execution", "execution", execution)
+		err = m.DeleteOutput(ctx, execution.Id)
+		if err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
+func (m *MinioRepository) DeleteOutput(ctx context.Context, id string) error {
+	log.DefaultLogger.Debugw("deleting test workflow output", "id", id)
+	return m.storage.DeleteFileFromBucket(ctx, m.bucket, bucketFolder, id)
+}