[WIP] KEP 4818: PodLifecycleSleepActionAllowZero #48439

sreeram-venkitesh · 2024-10-19T16:50:50Z

Description

Docs for KEP 4818: Allow zero value for Sleep Action of PreStop Hook.

Related PRs

Enhancements PR: KEP-4818: Allow zero value for Sleep Action of PreStop Hook enhancements#4855
Code PR: KEP-4818: Relaxed validation for allowing zero in PreStop hook sleep action kubernetes#127094

Issue

Closes: nil, part of kubernetes/enhancements#4818

sreeram-venkitesh · 2024-10-19T16:57:08Z

Placeholder PR for the KEP, will come back to this next week.

netlify · 2024-10-19T16:59:57Z

✅ Pull request preview available for checking

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`1ea5b20`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6715c1509619280008b82dc1
😎 Deploy Preview	https://deploy-preview-48439--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

sftim · 2024-10-19T17:44:47Z

...eference/command-line-tools-reference/feature-gates/pod-lifecycle-sleep-action-allow-zero.md

+  - stage: alpha 
+    defaultValue: false
+    fromVersion: "1.32"
+    toVersion: "1.32"


(nit)

Suggested change

toVersion: "1.32"

(because of https://kubernetes.io/docs/contribute/style/style-guide/#avoid-statements-about-the-future - toVersion: 1.32 means: this gate was no longer alpha in v1.33)

sftim · 2024-10-19T17:45:34Z

...eference/command-line-tools-reference/feature-gates/pod-lifecycle-sleep-action-allow-zero.md

+    fromVersion: "1.32"
+    toVersion: "1.32"
+---
+Enables setting zero value for the `sleep` action in Container lifecycle hooks.


Optionally:

Suggested change

Enables setting zero value for the `sleep` action in Container lifecycle hooks.

Enables setting zero value for the `sleep` action in

[container lifecycle hooks](/docs/concepts/containers/container-lifecycle-hooks/).

kannon92 · 2024-10-20T17:49:10Z

I think this needs to target dev-1.32.

sreeram-venkitesh · 2024-10-21T02:47:20Z

@kannon92 Ah I missed that, thanks for pointing it out Kevin!

Localizes image.md to Hindi

Made small corrections!!

It should match the flag definition https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/options.go#L81

According to https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/opts.go#L365 , the manifest content should be a map.

Also switched to a particular tag in the spec repo. Also called out the minor release number in the text of the reference. Signed-off-by: Mike Spreitzer <[email protected]>

Signed-off-by: xin.li <[email protected]>

Revert "update CODEOWNERS" This reverts commit d460a6a. mv ./README-xx.md ./content/xx/README.md update: README.md

Signed-off-by: Marko Mudrinić <[email protected]>

Use Kubernetes blue by referencing a variable.

k8s-ci-robot · 2024-10-21T02:49:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sftim for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

netlify · 2024-10-21T02:50:06Z

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name	Link
🔨 Latest commit	`1ea5b20`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6715c150c0b23400087d4df3

sreeram-venkitesh · 2024-10-21T02:51:13Z

I messed up the git history after rebasing, I'll fix it later today!

CC: @sftim

k8s-ci-robot · 2024-11-05T07:27:36Z

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chanieljdan · 2024-11-10T01:33:50Z

Hi @sreeram-venkitesh 👋,

A quick reminder to get your PR ready for review before the deadline, Tuesday November 19th 2024 at 18:00 PDT. For additional information, refer to: Documenting for a release - PR Ready for Review.

Thank you!

k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 19, 2024

k8s-ci-robot requested review from mickeyboxell and tengqm October 19, 2024 16:50

k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. language/en Issues or PRs related to English language labels Oct 19, 2024

sreeram-venkitesh mentioned this pull request Oct 19, 2024

Allow zero value for Sleep Action of PreStop Hook kubernetes/enhancements#4818

Open

4 tasks

sftim reviewed Oct 19, 2024

View reviewed changes

sreeram-venkitesh changed the base branch from main to dev-1.32 October 21, 2024 02:47

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 21, 2024

ChrisMcD1 and others added 14 commits October 21, 2024 08:19

Fix typo of selector-selector

0918d20

feature: include missing core object in glossary

d90e17c

fix: Improve PodTemplate glossary

4958f90

Localizes image.md

b14b16b

Localizes image.md to Hindi

Update image.md

38f02d0

Made small corrections!!

fix: use the correct flag name for allow metric label

1b52d37

It should match the flag definition https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/options.go#L81

Fix: use correct metric allow list manifest format

83eb3bb

According to https://github.com/kubernetes/kubernetes/blob/c15581b277e9e42d830898357fdbd92dcf7981c6/staging/src/k8s.io/component-base/metrics/opts.go#L365 , the manifest content should be a map.

Fix fragment in schema URL

dd0b965

Also switched to a particular tag in the spec repo. Also called out the minor release number in the text of the reference. Signed-off-by: Mike Spreitzer <[email protected]>

[zh-cn] sync configure-pod-configmap.md

fcfdd14

Signed-off-by: xin.li <[email protected]>

[zh-cn] sync concepts/containers/_index.md

3db8482

[zh] Sync pods/sidecar-containers.md

4f4f564

[zh] Sync cluster-administration/system-metrics.md

f542fa1

update CODEOWNERS

f644138

Revert "update CODEOWNERS" This reverts commit d460a6a. mv ./README-xx.md ./content/xx/README.md update: README.md

Change date for October 2024 releases

a1603b9

Signed-off-by: Marko Mudrinić <[email protected]>

sftim and others added 2 commits October 21, 2024 08:19

Refactor color use

4195266

Use Kubernetes blue by referencing a variable.

Added PodLifecycleSleepActionAllowZero feature gate

1ea5b20

sreeram-venkitesh force-pushed the 4818-allow-zero-for-prestop-hook branch from 92ef246 to 1ea5b20 Compare October 21, 2024 02:49

k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject area/localization General issues or PRs related to localization labels Oct 21, 2024

k8s-ci-robot added language/vi Issues or PRs related to Vietnamese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Oct 21, 2024

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] KEP 4818: PodLifecycleSleepActionAllowZero #48439

[WIP] KEP 4818: PodLifecycleSleepActionAllowZero #48439

sreeram-venkitesh commented Oct 19, 2024

sreeram-venkitesh commented Oct 19, 2024

netlify bot commented Oct 19, 2024 •

edited

Loading

sftim Oct 19, 2024

sftim Oct 19, 2024

kannon92 commented Oct 20, 2024

sreeram-venkitesh commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

netlify bot commented Oct 21, 2024

sreeram-venkitesh commented Oct 21, 2024

k8s-ci-robot commented Nov 5, 2024

chanieljdan commented Nov 10, 2024 •

edited

Loading

	Enables setting zero value for the `sleep` action in Container lifecycle hooks.
	Enables setting zero value for the `sleep` action in
	[container lifecycle hooks](/docs/concepts/containers/container-lifecycle-hooks/).

[WIP] KEP 4818: PodLifecycleSleepActionAllowZero #48439

Are you sure you want to change the base?

[WIP] KEP 4818: PodLifecycleSleepActionAllowZero #48439

Conversation

sreeram-venkitesh commented Oct 19, 2024

Description

Issue

sreeram-venkitesh commented Oct 19, 2024

netlify bot commented Oct 19, 2024 • edited Loading

✅ Pull request preview available for checking

sftim Oct 19, 2024

Choose a reason for hiding this comment

sftim Oct 19, 2024

Choose a reason for hiding this comment

kannon92 commented Oct 20, 2024

sreeram-venkitesh commented Oct 21, 2024

k8s-ci-robot commented Oct 21, 2024

netlify bot commented Oct 21, 2024

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

sreeram-venkitesh commented Oct 21, 2024

k8s-ci-robot commented Nov 5, 2024

chanieljdan commented Nov 10, 2024 • edited Loading

netlify bot commented Oct 19, 2024 •

edited

Loading

chanieljdan commented Nov 10, 2024 •

edited

Loading