-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcd: adjust e2e presubmit jobs #33330
etcd: adjust e2e presubmit jobs #33330
Conversation
* Don't set them as optional, as the jobs have been stable, according to TestGrid. * Set the RAM requests/limits to 4Gi, as based on the Grafana stats, ARM and AMD jobs have been using around 1Gi, so cutting the resources in half should be enough.
These jobs have been long running on the prow infrastructure by the work from the pull request kubernetes/test-infra#31257. By having them as required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Much appreciated @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ivanvc: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
These jobs have been long-running on the prow infrastructure, thanks to the work from the pull request kubernetes/test-infra#31257. Since they are required (kubernetes/test-infra#33330), it should be safe to remove the GitHub actions. Signed-off-by: Ivan Valdes <[email protected]>
ARM resources are to be adjusted, as I need to confirm with sig-infra where we can find the stats for the cluster where the jobs run.
Part of #32754 / kubernetes/k8s.io#6102