delete go.mod in root directory

[hwdef]

Fix #1813 again

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hwdef
To complete the pull request process, please assign timothysc after the PR has been reviewed.
You can assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fabriziopandini]

The go-mod file in the root directory gets automatically generate when updating go modules under kinder/ or operator/, so IMO there is no point in continuing to delete it
I'm +1 for closing this PR

[hwdef]

Maybe you can find a way to not generate it.
Or give a warning when viewing code, if someone generates this file.

This file is actually useless.

[fabriziopandini]

Feel free to open an issue and propose other solutions, but please take care such solutions are not adding any burden to people working in this repo.
In the meantime, I don't see any problem in keeping the file

[hwdef]

fine.

just close this.

[hwdef]

@fabriziopandini
What command did you used?
I try to update go modules under kinder/ or operator/, but go.mod in root directory is not recreate.

[hwdef]

/assign @neolit123

Can you give me some suggestions?
Or we can add go.mod to .gitignore.

[fabriziopandini]

TBH, it will be really weird for me to have go.mod in .gitignore, even weirder than having the file itself given that it does not cause any harm

As explained before, as a maintainer of this project, I don't want this to get into the way of contributors again given that after the first PR got merged it was regenerated by simply working on kinder/on the operator.

Also, as soon as the details about the move of kubeadm out of K/K will be addressed, this file will be required, so any effort to remove it is just temporary.

I'm -1 to get this merged
🤷‍♂️

[hwdef]

It is wrong to keep files just because there are no problems, and it will cause more and more garbage.
I looked at the file history, this file was submitted by you, and it is not surprising that you object to cleaning it.
Maybe others do not agree to clean up this file, but I still think that you uploaded this file as a mistake.
You can +1 or -1, but please don’t promote bad habits.

[hwdef]

@fabriziopandini
And please let me ask again, what command did you use to upgrade? Did you make a mistake that caused this file to be generated?

[fabriziopandini]

what command did you use to upgrade? Did you make a mistake that caused this file to be generated?

The file was generated working on the operator, but TBH I don't remember if this happened while updating some reference or by running some hack/verify script.
However this is going to be revised as per #2317, and this will revamp most of the initial experiment + update to the latest version of golang, so might be the problem will be fixed during this effort

[neolit123]

The file is not needed in general since the root folder is not a module. I can confirm that something generates it under certain conditions. Instead of this pr if you can find what of our scripts generates it and change that behavior it would be the better fix.