-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add labels to metrics #1673
base: main
Are you sure you want to change the base?
chore: add labels to metrics #1673
Conversation
Hi @marcelocyreno. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: marcelocyreno The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4ef8d23
to
c898ca1
Compare
/ok-to-test |
c898ca1
to
a7d02ff
Compare
/retest |
/test pull-secrets-store-csi-driver-image-scan |
/hold pod_name, pod_namespace and secret_provider_class are all unbounded cardinality which is not appropriate for metrics. |
What type of PR is this?
/kind feature
/kind documentation
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Fixes #1344
Special notes for your reviewer:
This PR contains the minor refinements suggested in the review of #1433.
Original work credit goes to @Suraiya-Hameed.
TODOs: