Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GCP SA json for auth #1588

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Use GCP SA json for auth #1588

wants to merge 2 commits into from

Conversation

NaMNDV
Copy link

@NaMNDV NaMNDV commented Jul 30, 2024

/kind migration

Testcase Migration for GCP Provider.

Partial revert of #641 to use GCP SA json as secret from GitHub Secrets and use that to authenticate GCP Secrets.

Since GCP Prow is migrating to EKS Prow, this is a temporary workaround to make sure the smooth transition of test cases, upon clarity we will build a permanent solution to use federated WI in EKS Prow.

  • squashed commits
  • includes documentation
  • adds unit tests

@k8s-ci-robot
Copy link
Contributor

@NaMNDV: The label(s) kind/migration cannot be applied, because the repository doesn't have them.

In response to this:

/kind migration

Testcase Migration for GCP Provider.

Partial revert of #641 to use GCP SA json as secret from GitHub Secrets and use that to authenticate GCP Secrets.

Since GCP Prow is migrating to EKS Prow, this is a temporary workaround to make sure the smooth transition of test cases, upon clarity we will build a permanent solution to use federated WI in EKS Prow.

  • squashed commits
  • includes documentation
  • adds unit tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 30, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: NaMNDV
Once this PR has been reviewed and has the lgtm label, please assign ritazh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @NaMNDV. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 30, 2024
@BenTheElder
Copy link
Member

Since GCP Prow is migrating to EKS Prow,

That's not it, we're moving jobs to either a GKE cluster running in kubernetes.io (SIG K8s Infra) or an EKS cluster running in SIG K8s Infra's accounts, just not GKE clusters in google.com, or any other company internal non-community-operated assets.

full context: https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU/m/11sDguoxAQAJ

@BenTheElder
Copy link
Member

see also: #1583

@aramase
Copy link
Member

aramase commented Aug 1, 2024

Since GCP Prow is migrating to EKS Prow,

That's not it, we're moving jobs to either a GKE cluster running in kubernetes.io (SIG K8s Infra) or an EKS cluster running in SIG K8s Infra's accounts, just not GKE clusters in google.com, or any other company internal non-community-operated assets.

full context: https://groups.google.com/a/kubernetes.io/g/dev/c/p6PAML90ZOU/m/11sDguoxAQAJ

@NaMNDV could you look at this? If you use the GKE cluster, you should be able to use workload identity?

@aramase
Copy link
Member

aramase commented Aug 14, 2024

@NaMNDV ping on this! Have you had a chance to look at the required resources to re-enable CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants