Add content write permissions to release jobs

[dgrisonnet]

This should work around the org-wide restriction on github actions write permission to the repos and fix the issue I encountered when releasing v0.7.2 where the jobs to publish the assets failed: https://github.com/kubernetes-sigs/metrics-server/actions/runs/10593979544

[k8s-ci-robot]

This issue is currently awaiting triage.

If metrics-server contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[stevehipwell]

Is it worth explicitly setting the default workflow level permissions for the other 2 workflows in this PR?

[dgrisonnet]

@stevehipwell I udpated the PR, is this what you had in mind? I removed the top-level permissions entirely as these are inherited from the repo settings which sets everything to read-all.

[stevehipwell]

@dgrisonnet setting the top level permissions is a best practice as it stops accidental (or deliberate) permission creep. Tools such as the OSSF Scorecard will warn if this isn't set.

FYI I can recommend using https://app.stepsecurity.io/secureworkflow with the agent option unchecked to check GH workflows are secure, this is what the OSSF Scorecard recommends using too.

[dgrisonnet]

Oh I see, that makes sense. Thanks for the tip, I'll run the workflow through that tool

[stevehipwell]

@dgrisonnet I still think it'd be worth adding the default to the other workflows while you're doing these ones.

[stevehipwell]

@dgrisonnet are you still working on this?

[dgrisonnet]

Yes sorry about that, I missed your last comment

[stevehipwell]

/lgtm

[yangjunmyfm192085]

/test pull-metrics-server-verify

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, yangjunmyfm192085

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dgrisonnet]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment