-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[KEP] Update KEP #993 - Add retry mechanism to AdmissionChecks #3261
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: PBundyra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/assign @mimowo |
// backoffMaxSeconds: 600 | ||
// | ||
// +listType=map | ||
DefaultRequeuingStrategy *RequeuingStrategy `json:defaultRequeuingStrategy` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It this configuration going to be used to configure the mechanism based on this hard-coded values:
kueue/pkg/controller/admissionchecks/provisioning/controller.go
Lines 54 to 56 in 9332a5a
defaultMaxRetries = 3 | |
defaultMinBackoffSeconds = 60 // 1 min | |
defaultMaxBackoffSeconds = 1800 // 30 min |
Please clarify in the KEP, I would prefer to make the existing mechanism configurable and we already have an issue for it #1353. If we reuse the mechanism, can we reuse the same defaults, or state clearly that we are changing the defaults.
type Configuration struct { | ||
... | ||
// admissionCheckRetryStrategy defines strategy for retrying AdmissionChecks | ||
// +optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for the tags in the global configuration as this is not CRD.
// backoffBaseSeconds: 60 | ||
// backoffMaxSeconds: 600 | ||
// | ||
// +listType=map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can drop it.
In my opinion we should let individual admission check controllers implement their own retry policy, not all ACCs need this and having another actor managing its ACStates makes room for conflicts or needs additional logic to avoid them. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Propose changes to introduce retry mechanism for AdmissionChecks
Which issue(s) this PR fixes:
Part of #3258
Special notes for your reviewer:
Does this PR introduce a user-facing change?