-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user documentation for KEP-2937 to website #3175
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: dgrove-oss The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @dgrove-oss. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/ok-to-test |
Waiting on #3026. /hold Doc looks good to me though. |
/cc |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also explain the role of the WorkloadResourceRequestsSummary
, and I would suggest it as a recommendation to provide visibility into the summary of the resources.
I expanded the example of troubleshooting a pending Job to show I thought about showing two yaml blocks; one with the feature enabled and one without (ie, what was there before), but it seemed like overkill. I could easily change it if that is preferred though. |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Adds user-facing documentation on configurable resource transformations (KEP-2937) to website
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I'm putting NONE for the release note, because #3026 which is the implementation PR contains the release note text.
Written under the assumption that we'll be merge 3026 in time to make 0.9.
Does this PR introduce a user-facing change?