-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s 1.29 bump #1633
k8s 1.29 bump #1633
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
@kannon92 Hi! Are you still here? I think we should include this in the next new minor version. |
I updated the PR but I need someone with Kueue experience to look into these errors. I see two groups of failures:
And the pkg/controller/job/pod has the following error while running make test.
Happy to resolve them if someone else can suggest a fix. Otherwise, I'm not sure how much progress I can make as I haven't done a lot of Kueue development lately. |
Running
@trasc At a quick glance you added
We are getting |
/cc @trasc |
I don't think I'll be able to hit that february deadline as I'll be traveling. |
the first issue with cannot infer can probably be easily fixed by wrapping the nil with type I'm not sure about the missing reconcile error. Probably can take a look tomorrow. |
Thank you! That fix worked like a charm. Still got the reconcile error and it looks to also impact 1.29 e2e test |
@@ -109,7 +109,7 @@ func TestValidateResourceFlavor(t *testing.T) { | |||
Value: "v", | |||
Effect: corev1.TaintEffectNoSchedule, | |||
}, ""), | |||
field.NotSupported(field.NewPath("spec", "tolerations").Index(2).Child("effect"), corev1.TaintEffect("not-valid"), nil), | |||
field.NotSupported(field.NewPath("spec", "tolerations").Index(2).Child("effect"), corev1.TaintEffect("not-valid"), []string{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
field.NotSupported(field.NewPath("spec", "tolerations").Index(2).Child("effect"), corev1.TaintEffect("not-valid"), []string{}), | |
field.NotSupported(field.NewPath("spec", "tolerations").Index(2).Child("effect"), corev1.TaintEffect("not-valid"), []corev1.TaintEffect{}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated.
For the flaky e2e multikueue test we have #1659 under review. For
It looks like the TypeMeta of the object in kueue/pkg/controller/jobs/pod/pod_controller_test.go Lines 2492 to 2507 in b7fc93f
is not populated, you could : a. get the GVK from the clients schema
b. do a type assertion instead |
If this is just about unit tests, it is probably ok to go with b as simpler. |
@trasc I guess that the root cause of the TypeMeta not being populated is kubernetes-sigs/controller-runtime#2633. |
Pushed a fix for each. Thank you for looking into that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: ffea7a787d1f05b97f48c6426da47254625ea516
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kannon92, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Update kubernetes to 0.29 api changes.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
I see two groups of failures:
Error is "cannot infer t" and these errors are in pkg/webhooks/resourceflavor_webhook_test.go and pkg/webhooks/workload_webhooks_test.go.
And the pkg/controller/job/pod has the following error while running
make test
.Does this PR introduce a user-facing change?