🐛 Fix HasResource pkg method to properly stop when a match is found #4190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the HasResource method to correctly stop the iteration when a matching GVK is found. - Replaced the immediate return inside the loop with a boolean flag and a break statement to ensure the function exits early when a resource is found. - This resolves the issue where the method was not stopping as expected after finding a matching resource
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
commented
Sep 23, 2024
camilamacedo86
added
the
lgtm
camilamacedo86
merged commit c810d8d
into
kubernetes-sigs:master
14 of 17 checks passed
TAM360
pushed a commit
to TAM360/kubebuilder
that referenced
this pull request
Sep 26, 2024
…ubernetes-sigs#4190) Fix HasResource method to properly stop when a match is found - Updated the HasResource method to correctly stop the iteration when a matching GVK is found. - Replaced the immediate return inside the loop with a boolean flag and a break statement to ensure the function exits early when a resource is found. - This resolves the issue where the method was not stopping as expected after finding a matching resource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PS.: This issue was found when I was implementing the e2e tests for generate alpha command: #4181