🐛 Enhances the webhook test template.

[mogsie]

The webhook scaffold had some oddly indented regions, resulting in the generated source code having a mix of tabs and spaces, and was generally looking quite ugly.

The gomega asserions are too chatty; errors, and return values are checked after first being assigned as variables in scope. This is not needed, and Gomega checks all of this for us:

• Expect(someFunc()).Error().To(HaveOccurred()) checks both the error, but also that the other return values are zero or nil.
• Expect(someFunc()).To(ContainSubstring("X")) checks both the return value and verifies that the error is nil.

Fixes #4148. Part of #4135.

• Fixes odd indentation, now it is in line with the other scaffolds
• Simplifies gomega assertions, to use fewer statements
• Updated the cronjob tutorial's tests too

[k8s-ci-robot]

Hi @mogsie. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[camilamacedo86]

Thank you 🥇
It is great!

/lgtm
/approved
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, mogsie

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment