🌱 cleanup: simplify and consolidate testdata samples #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
3 times, most recently
from
c24bbb5
to
1f2332f
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
1f2332f
to
942370a
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
942370a
to
f6ee9ab
Compare
k8s-ci-robot
added
the
needs-rebase
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
f6ee9ab
to
df7dfa6
Compare
k8s-ci-robot
added
needs-rebase
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
df7dfa6
to
ee3fc91
Compare
k8s-ci-robot
removed
the
needs-rebase
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
ee3fc91
to
d8f35b7
Compare
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
camilamacedo86
force-pushed
the
fix-make-build-installer
branch
from
d8f35b7
to
bca81f3
Compare
|
I am moving forward with this one. |
camilamacedo86
added
lgtm
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Sep 11, 2024
The testdata samples are designed to showcase various options for users and enable comprehensive testing of tool commands. By aggregating the Grafana and deploy-image plugins into the multigroup layout, we streamline test coverage and reduce redundancy. This change ensures all options are tested within the multigroup layout while keeping project-v4 with and without the optional plugins, to help us ensure the references for users and keep our CI tests. Now, instead of having a separate sample for each optional plugin, we have: - project-v4 - project-v4-multigroup-with-plugins - project-v4-with-plugins This consolidation reduces the number of samples and tests, making the codebase easier to maintain without sacrificing test coverage or usability for users.
k8s-ci-robot
added a commit
that referenced
this pull request
Sep 11, 2024
🌱 cleanup: simplify and consolidate testdata samples #4126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testdata samples are designed to showcase various options for users and enable comprehensive testing of tool commands. By aggregating the Grafana and deploy-image plugins into the multigroup layout, we streamline test coverage and reduce redundancy. This change ensures all options are tested within the multigroup layout while keeping project-v4 with and without the optional plugins, to help us ensure the references for users and keep our CI tests.
Now, instead of having a separate sample for each optional plugin, we have:
This consolidation reduces the number of samples and tests, making the codebase easier to maintain without sacrificing test coverage or usability for users.