Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GetWaitingPod #121

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Support GetWaitingPod #121

wants to merge 15 commits into from

Conversation

chansuke
Copy link
Member

@chansuke chansuke commented Sep 14, 2024 •
edited
Loading

What type of PR is this?

Adding GetWaitingPod of framework.Handle

What this PR does / why we need it:

Which issue(s) this PR fixes:

Partof #73

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Support GetWaitingPod

What are the benchmark results of this change?

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chansuke
Once this PR has been reviewed and has the lgtm label, please assign sanposhiho for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 14, 2024
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Sep 18, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 27, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 19, 2024
@chansuke chansuke marked this pull request as ready for review October 19, 2024 11:13
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 19, 2024
@chansuke
Copy link
Member Author

searching Test_guestPool_bindingCycles error

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sanposhiho
Copy link
Member

/cc @utam0k @Gekko0114

sanposhiho
sanposhiho reviewed Nov 12, 2024
View reviewed changes
guest/handle/imports.go
@@ -20,5 +20,11 @@ package handle

import "sigs.k8s.io/kube-scheduler-wasm-extension/guest/internal/mem"

//go:wasmimport k8s.io/scheduler handle.get_waiting_pod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//go:wasmimport k8s.io/scheduler handle.get_waiting_pod
//go:wasmimport k8s.io/scheduler handle.allow_waiting_pod

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't see the implementation of allow_waiting_pod in the host side.
Do you want to keep the scope of this PR as only getWaitingPod? Or do you want to include that in the PR too? Either is fine to me.

scheduler/plugin/host_test.go
@@ -96,39 +95,31 @@ func initKlog(t *testing.T, buf *bytes.Buffer) {
klog.SetOutput(buf)
}

func Test_k8sHandleEventRecorderEventFn(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this test removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sanposhiho sanposhiho sanposhiho left review comments

@codefromthecrypt codefromthecrypt Awaiting requested review from codefromthecrypt

@Gekko0114 Gekko0114 Awaiting requested review from Gekko0114

@utam0k utam0k Awaiting requested review from utam0k

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chansuke @k8s-ci-robot @sanposhiho