-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ImplementationSpecific
instead of Prefix
for pathType example
#3315
base: main
Are you sure you want to change the base?
Conversation
Since the example is using a regular express to match more than the prefix I think the recommendation would be to use `ImplementationSpecific` instead.
Welcome @sontek! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sontek The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @sontek. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for your report. This is because in the new version of the ingress-nginx project, some restrictions have been added to avoid security issues. /lgtm |
/ok-to-test |
@sontek: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@tao12345666333 @neolit123 Looks like we need more than the lgtm to get this merged |
unfortunately the ingress section grew organically and there are multiple implementations, is this compatible with all of them? |
Since the example is using a regular express to match more than the prefix I think the recommendation would be to use
ImplementationSpecific
instead. You receive:When doing that.