Unwrap original error from temporary when reporting to operation_errors metric

[eipi-one]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:
When CreateVolume is executed, the csi provisioner expects either "final" or "temporary" errors. If we report final error when filestore instance creation could be ongoing or an instance is already created, then a PVC deletion before successful volume creation could lead to disk leakage as DeleteVolume won't happen.

To prevent filestore instance leakage in FSCSI driver, we changed the error codes returned in CreateVolume to return the Unavailable temporary error code (see #924). As a consequence of this most of the interesting errors we get from CreateVolume, all return Unavailable error code, which is filtered out from SLO.

This PR reports the original error code to the operation_errors metric.

Which issue(s) this PR fixes:

Fixes #925

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

     None

[linux-foundation-easycla]

• ✅login: eipi-one / (f6d8964)

The committers listed above are authorized under a signed CLA.

[k8s-ci-robot]

Welcome @eipi-one!

It looks like this is your first PR to kubernetes-sigs/gcp-filestore-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/gcp-filestore-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @eipi-one. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[riteshghorse]

LGTM

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eipi-one, riteshghorse
Once this PR has been reviewed and has the lgtm label, please assign mattcary for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[eipi-one]

r: @riteshghorse

[eipi-one]

r: @leiyiz

[eipi-one]

@leiyiz Friendly ping.

[leiyiz]

/ok-to-release

[leiyiz]

in general lgtm, just 1 nit

[leiyiz]

add a new line here at the end of the file

[leiyiz]

/ok-to-test

[k8s-ci-robot]

@eipi-one: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-gcp-filestore-csi-driver-verify	f6d8964	link	true	/test pull-gcp-filestore-csi-driver-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.