Do not expose the AWS role external id in the logs

[iul1an]

Description

This change conceals the AWS ExternalId from application logs to mitigate security risks, as exposing this identifier could enable attackers to exploit it for unauthorized cross-account access or privilege escalation.

Fixes #4277

Checklist

• Unit tests updated
• End user documentation updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: iul1an / name: Iulian Mandache (90c15d7)

[k8s-ci-robot]

Welcome @iul1an!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @iul1an. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mloiseleur]

/ok-to-test

[mloiseleur]

/lgtm

[szuecs]

why do we need this?
I guess we do not need this, so please cleanup

[iul1an]

The label is needed to mask the AWSAssumeRoleExternalID value in the logs.

[iul1an]

relevant code:

• external-dns/pkg/apis/externaldns/types.go

  Lines 37 to 39 in f5f7d23

  	const (
  	passwordMask = "******"
  	)

• external-dns/pkg/apis/externaldns/types.go

  Lines 375 to 394 in f5f7d23

  	func (cfg *Config) String() string {
  	// prevent logging of sensitive information
  	temp := *cfg
  	t := reflect.TypeOf(temp)
  	for i := 0; i < t.NumField(); i++ {
  	f := t.Field(i)
  	if val, ok := f.Tag.Lookup("secure"); ok && val == "yes" {
  	if f.Type.Kind() != reflect.String {
  	continue
  	}
  	v := reflect.ValueOf(&temp).Elem().Field(i)
  	if v.String() != "" {
  	v.SetString(passwordMask)
  	}
  	}
  	}
  	return fmt.Sprintf("%+v", temp)
  	}

[iul1an]

@mloiseleur Can you review again, please? I had to rebase.

[mloiseleur]

/lgtm
/assign @szuecs
/unassign @mloiseleur

[szuecs]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [szuecs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[szuecs]

debug logs enable the user to figure out if the role id is wrong or something like that, so seems fine.
Thanks for the contribution