Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(digitalocean): add mx and txt records support #4690

Merged
merged 4 commits into from
Sep 30, 2024
Merged

feat(digitalocean): add mx and txt records support #4690

merged 4 commits into from
Sep 30, 2024

Conversation

simonoff
Copy link
Contributor

Description

Add support for MX and TXT records creation for DigitalOcean provider via CRD Source.

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @simonoff!

It looks like this is your first PR to kubernetes-sigs/external-dns 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/external-dns has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 19, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @simonoff. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2024
mloiseleur
mloiseleur reviewed Aug 20, 2024
View reviewed changes
docs/tutorials/txt-record.md Outdated
You can create and manage TXT records with the help of [CRD source](../contributing/crd-source.md)
and `DNSEndpoint` CRD. Currently, this feature is only supported by `digital_ocean` providers.

In order to start managing MX records you need to set the `--managed-record-types TXT` flag.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In order to start managing MX records you need to set the `--managed-record-types TXT` flag.
In order to start managing MX records you need to set the `--managed-record-types MX` flag.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Forgot to change there.

mloiseleur
mloiseleur reviewed Aug 20, 2024
View reviewed changes
provider/digitalocean/digital_ocean.go Outdated
Comment on lines 305 to 316
priority, domain, err := parseMxTarget(data)
if err == nil {
request.Priority = int(priority)
request.Data = provider.EnsureTrailingDot(domain)
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When error != nil, it should be (at least) displayed to the user and/or sent to the calling method.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically after will be a raise from DO client. But I can add a logging.

mloiseleur
mloiseleur reviewed Aug 20, 2024
View reviewed changes
provider/digitalocean/digital_ocean.go Outdated
}

if c.Options.Type == endpoint.RecordTypeMX {
logFields["priotity"] = c.Options.Priority
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
logFields["priotity"] = c.Options.Priority
logFields["priority"] = c.Options.Priority

@mloiseleur
Copy link
Contributor

Since the typo was not detected by the test
=> Wdyt of adding a test for priority ?

@simonoff
Copy link
Contributor Author

Since the typo was not detected by the test => Wdyt of adding a test for priority ?

Such type is for logs. Not for a exact functionality.

@mloiseleur
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 3, 2024
@szuecs
Copy link
Contributor

szuecs commented Sep 5, 2024

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: szuecs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2024
Raffo
Raffo reviewed Sep 5, 2024
View reviewed changes
provider/digitalocean/digital_ocean.go
Comment on lines +310 to +315
log.WithFields(log.Fields{
"domain": domain,
"dnsName": name,
"recordType": recordType,
"data": data,
}).Warn("Unable to parse MX target")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just log the error? what happens with the request that gets returned?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will incomplete and DO will return error after trying to create such record. As any error if you put a broken data in values to DO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. There is a merge conflict now, if you get that fixed, I'm happy to approve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 6, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2024
@simonoff
Copy link
Contributor Author

@mloiseleur Hi! What do you think about merging this staff?

@mloiseleur
Copy link
Contributor

/retitle feat(digitalocean): add mx and txt records support

@k8s-ci-robot k8s-ci-robot changed the title Mx and txt records for do feat(digitalocean): add mx and txt records support Sep 30, 2024
@mloiseleur
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2024
@k8s-ci-robot k8s-ci-robot merged commit 45257fb into kubernetes-sigs:master Sep 30, 2024
12 checks passed
@simonoff
Copy link
Contributor Author

@mloiseleur thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur mloiseleur left review comments

@Raffo Raffo Raffo left review comments

@szuecs szuecs Awaiting requested review from szuecs

Assignees

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@simonoff @k8s-ci-robot @mloiseleur @szuecs @Raffo