Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add elezar as approver #32

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add elezar as approver #32

merged 1 commit into from
Oct 23, 2023

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Sep 13, 2023

No description provided.

@elezar
Add elezar as approver
d42bd19 
Signed-off-by: Evan Lezar <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 13, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 14, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 14, 2023

@elezar do you happen to know why do-not-merg/invalid-owners-file label is set?

@bart0sh
Copy link
Contributor

bart0sh commented Sep 14, 2023

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@bart0sh
Copy link
Contributor

bart0sh commented Sep 14, 2023

found it:

elezar
User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@elezar
Copy link
Contributor Author

elezar commented Sep 15, 2023

Yes, I will have a look at what's required for org membership next week. Happy to leave this open until I get that sorted out.

@elezar
Copy link
Contributor Author

elezar commented Sep 21, 2023

I have created kubernetes/org#4472. If that gets approved, I will retrigger this one.

@elezar
Copy link
Contributor Author

elezar commented Oct 20, 2023

Since kubernetes/org#4472 has been addressed, could we look at merging this?

@pohly
Copy link
Contributor

pohly commented Oct 20, 2023

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bart0sh, elezar, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@klueska
Copy link
Contributor

klueska commented Oct 23, 2023

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit e55fb90 into kubernetes-sigs:main Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@klueska klueska Awaiting requested review from klueska

Assignees

@pohly pohly

@bart0sh bart0sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@elezar @bart0sh @pohly @k8s-ci-robot @klueska