log warning if error and non-zero Result returned

Signed-off-by: Stefan Büringer [email protected]
kubernetes-sigs · Aug 17, 2023 · 3b25387 · 3b25387
1 parent 480fc5b
commit 3b25387
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/pkg/internal/controller/controller.go b/pkg/internal/controller/controller.go
@@ -323,6 +323,9 @@ func (c *Controller) reconcileHandler(ctx context.Context, obj interface{}) {
 		}
 		ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc()
 		ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, labelError).Inc()
+		if !result.IsZero() {
+			log.Info("Warning: error and non-zero Result returned, ignoring Result")
+		}
 		log.Error(err, "Reconciler error")
 	case result.RequeueAfter > 0:
 		log.V(5).Info(fmt.Sprintf("Reconcile done, requeueing after %s", result.RequeueAfter))