Skip to content

⚠ Introduce Metrics Options struct & secure metrics serving #1837

⚠ Introduce Metrics Options struct & secure metrics serving

⚠ Introduce Metrics Options struct & secure metrics serving #1837

Triggered via pull request July 15, 2023 13:17
Status Failure
Total duration 4m 9s
Artifacts

golangci-lint.yml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors
lint: pkg/manager/doc.go#L1
: # sigs.k8s.io/controller-runtime/pkg/manager [sigs.k8s.io/controller-runtime/pkg/manager.test]
lint: pkg/manager/manager_test.go#L572
cannot use func(addr string) (net.Listener, error) {…} (value of type func(addr string) ("net".Listener, error)) as func(addr string, insecureServing bool) ("net".Listener, error) value in struct literal
lint: pkg/manager/manager_test.go#L574
not enough arguments in call to metrics.NewListener
lint: pkg/manager/manager_test.go#L585
not enough arguments in call to metrics.NewListener
lint: pkg/manager/manager_test.go#L591
cannot use func(addr string) (net.Listener, error) {…} (value of type func(addr string) ("net".Listener, error)) as func(addr string, insecureServing bool) ("net".Listener, error) value in struct literal
lint: pkg/manager/manager_test.go#L593
not enough arguments in call to metrics.NewListener
lint: pkg/manager/manager_test.go#L1179
cannot use func(addr string) (net.Listener, error) {…} (value of type func(addr string) ("net".Listener, error)) as func(addr string, insecureServing bool) ("net".Listener, error) value in struct literal
lint: pkg/manager/manager_test.go#L1181
not enough arguments in call to metrics.NewListener
lint: pkg/manager/example_test.go#L28
could not import sigs.k8s.io/controller-runtime/pkg/manager (-: # sigs.k8s.io/controller-runtime/pkg/manager [sigs.k8s.io/controller-runtime/pkg/manager.test]
lint: pkg/manager/manager_test.go#L572
cannot use func(addr string) (net.Listener, error) {…} (value of type func(addr string) ("net".Listener, error)) as func(addr string, insecureServing bool) ("net".Listener, error) value in struct literal