Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(machinepool): clear VirtualMachineProfile if no model/custom data update #5164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(machinepool): clear VirtualMachineProfile if no model/custom data update #5164

wants to merge 1 commit into from

Commits on Oct 9, 2024

  1. fix(machinepool): clear VirtualMachineProfile if no model/custom data… 

    … update

Scale up/down with MachinePool always updates the VM image model to use. This change sets the VirtualMachineProfile to nil when no change is necessary and ensures therefore less churn on scale up/downs leading to model updates which may require manual fixing

Fixes some linting errors related to unnecessary params, too.
    @mweibel
    mweibel committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    c8cf42a View commit details
    Browse the repository at this point in the history