-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.11] Set correct fqdn on private cluster #4242
[release-1.11] Set correct fqdn on private cluster #4242
Conversation
Hi @mihaiandreiratoiu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
89d61e7
to
a0878e5
Compare
a0878e5
to
de721bb
Compare
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-1.11 #4242 +/- ##
=============================================
Coverage 56.69% 56.70%
=============================================
Files 187 187
Lines 19214 19222 +8
=============================================
+ Hits 10893 10899 +6
- Misses 7691 7693 +2
Partials 630 630
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: a855193433db6baa8d9a411da42b285eaf36b85f
|
What type of PR is this?
Adapted from #4225
/kind bug
What this PR does / why we need it:
On private cluster with the managedcontrolplane
The fqdn property is not available. The cluster defaults to the
privateFQDN
The Cluster resource remains in provisioning state due to the capz error
TODOs:
Release note: