-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] fix endless reconciliation on AKS system node labels #3989
[release-1.10] fix endless reconciliation on AKS system node labels #3989
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #3989 +/- ##
=============================================
Coverage 54.27% 54.27%
=============================================
Files 186 186
Lines 18861 18866 +5
=============================================
+ Hits 10237 10240 +3
- Misses 8069 8071 +2
Partials 555 555
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 69da9ee38c7c0a8671eba3562b025fbf37af8084
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/area managedclusters
What this PR does / why we need it: Manual cherry-pick of #3975.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
Release note: