-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] Label kubeconfig with cluster name #3957
[release-1.10] Label kubeconfig with cluster name #3957
Conversation
/retitle [release-1.10] Label kubeconfig with cluster name |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #3957 +/- ##
================================================
- Coverage 54.26% 54.26% -0.01%
================================================
Files 186 186
Lines 18854 18855 +1
================================================
Hits 10231 10231
- Misses 8068 8069 +1
Partials 555 555
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nojnhuh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 82a8c83162492203a4f7a289774a7f260a30d05a
|
/lgtm |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In #3703 CAPZ added a kubeconfig label to comply with changes needed for CAPI v1.5.0 migration. But this change is not in an existing release and the lack of this label is causing problems for users trying to combine CAPI 1.5.x with a CAPZ release, so let's backport that change.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
TODOs:
Release note: