Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] Label kubeconfig with cluster name #3957

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented Sep 5, 2023

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

In #3703 CAPZ added a kubeconfig label to comply with changes needed for CAPI v1.5.0 migration. But this change is not in an existing release and the lack of this label is causing problems for users trying to combine CAPI 1.5.x with a CAPZ release, so let's backport that change.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@mboersma
Copy link
Contributor Author

mboersma commented Sep 5, 2023

/retitle [release-1.10] Label kubeconfig with cluster name

@k8s-ci-robot k8s-ci-robot changed the title [release-1.10] Label kubeconfig for caching [release-1.10] Label kubeconfig with cluster name Sep 5, 2023
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (85b34ef) 54.26% compared to head (f000d8d) 54.26%.
Report is 3 commits behind head on release-1.10.

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #3957      +/-   ##
================================================
- Coverage         54.26%   54.26%   -0.01%     
================================================
  Files               186      186              
  Lines             18854    18855       +1     
================================================
  Hits              10231    10231              
- Misses             8068     8069       +1     
  Partials            555      555              
Files Changed Coverage Δ
azure/scope/managedcontrolplane.go 24.57% <0.00%> (-0.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 82a8c83162492203a4f7a289774a7f260a30d05a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 5, 2023
@CecileRobertMichon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit f23c804 into kubernetes-sigs:release-1.10 Sep 5, 2023
19 checks passed
@mboersma mboersma deleted the label-kubeconfig-for-caching branch September 5, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants