Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CVE-2022-41723 #3904

Closed

Conversation

xiujuanx
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
Fix CVE-2022-41723 for golang.org/x/net package. This CVE is fixed in v0.7.0 version, so bump net package to v0.7.0.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

fix CVE-2022-41723

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @xiujuanx. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mboersma
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 29, 2023
@k8s-ci-robot
Copy link
Contributor

@xiujuanx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-v1beta1 ca01786 link true /test pull-cluster-api-provider-azure-e2e-v1beta1
pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1 ca01786 link true /test pull-cluster-api-provider-azure-apiversion-upgrade-v1beta1
pull-cluster-api-provider-azure-e2e-aks-v1beta1 ca01786 link true /test pull-cluster-api-provider-azure-e2e-aks-v1beta1
pull-cluster-api-provider-azure-ci-entrypoint-v1beta1 ca01786 link true /test pull-cluster-api-provider-azure-ci-entrypoint-v1beta1
pull-cluster-api-provider-azure-test-v1beta1 ca01786 link true /test pull-cluster-api-provider-azure-test-v1beta1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mboersma
Copy link
Contributor

@xiujuanx I see this is targeting the release-1.6 branch. That's been out of support for quite a while, and we don't plan to do any more releases in that series.

The oldest supported branch is release-1.9, and it has golang.org/x/net at v0.10.0. So I think CAPZ is covered already.

@xiujuanx
Copy link
Contributor Author

xiujuanx commented Aug 29, 2023

Thanks @mboersma for your information! BTW, does the above test fail because release-1.6 is not supported?

@CecileRobertMichon
Copy link
Contributor

CecileRobertMichon commented Aug 29, 2023

BTW, does the above test fail because release-1.6 is not supported?

yes, the tests in old release branches are not maintained

We don't plan on merging this, please update your version of CAPZ to a supported one.

/close

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Closed this PR.

In response to this:

BTW, does the above test fail because release-1.6 is not supported?

yes, the tests in old release branches are not maintained

We don't plan on merging this

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants