Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] add controller: true to azure.json Secret ownerRef #3818

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3811

/assign nojnhuh

Fixed a bug preventing azure.json Secrets from being reconciled

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 9, 2023
@nojnhuh nojnhuh force-pushed the cherry-pick-3811-to-release-1.9 branch from 41a5b38 to 3f8258c Compare August 9, 2023 15:30
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04% 🎉

Comparison is base (4ed93b9) 52.90% compared to head (3f8258c) 52.94%.
Report is 5 commits behind head on release-1.9.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #3818      +/-   ##
===============================================
+ Coverage        52.90%   52.94%   +0.04%     
===============================================
  Files              182      182              
  Lines            18250    18271      +21     
===============================================
+ Hits              9655     9674      +19     
- Misses            8055     8057       +2     
  Partials           540      540              
Files Changed Coverage Δ
controllers/azurejson_machine_controller.go 47.68% <100.00%> (+0.34%) ⬆️
controllers/azurejson_machinepool_controller.go 51.07% <100.00%> (+0.35%) ⬆️
...ontrollers/azurejson_machinetemplate_controller.go 47.69% <100.00%> (+0.40%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 9, 2023

I had to tweak this cherry-pick to use the pointer package instead of ptr since that change isn't going to be backported.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 04b00b0ef1733972084f9095471702620b93838c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Aug 9, 2023

/retest

@k8s-ci-robot k8s-ci-robot merged commit cc219ab into kubernetes-sigs:release-1.9 Aug 9, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants