fix AuthorizedIPRanges disable -> enable bug #3806
Conversation
- update AzureSDK once with empty slice and then ignore changes
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/L
|
I will squash the commits once lgtm-ed. |
|
@nawazkh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| func getIdentity(identity *infrav1.Identity) (managedClusterIdentity *containerservice.ManagedClusterIdentity, err error) { | ||
| if identity.Type == "" { | ||
| return | ||
| } | ||
|
|
||
| managedClusterIdentity = &containerservice.ManagedClusterIdentity{ | ||
| Type: containerservice.ResourceIdentityType(identity.Type), | ||
| } | ||
| if managedClusterIdentity.Type == containerservice.ResourceIdentityTypeUserAssigned { | ||
| if identity.UserAssignedIdentityResourceID == "" { | ||
| err = errors.Errorf("Identity is set to \"UserAssigned\" but no UserAssignedIdentityResourceID is present") | ||
| return | ||
| } | ||
| managedClusterIdentity.UserAssignedIdentities = map[string]*containerservice.ManagedClusterIdentityUserAssignedIdentitiesValue{ | ||
| identity.UserAssignedIdentityResourceID: {}, | ||
| } | ||
| } | ||
| return | ||
| } |
There was a problem hiding this comment.
This is not my change.. Probing why this got pulled in.
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Closing this PR since the cherry-pick is behaving weirdly. |
|
/close |
|
@nawazkh: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
//nolint:gocycloto theParameters()function from main since [release-1.10] fix AuthorizedIPRanges disable -> enable bug #3800 was erroring out on go-cyclomexic complexity (A lot of nil checks).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
TODOs:
Release note: