-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.10] fix AuthorizedIPRanges disable -> enable bug #3805
[release-1.10] fix AuthorizedIPRanges disable -> enable bug #3805
Conversation
I will squash the commits once lgtm-ed. |
/retitle [release-1.10] fix AuthorizedIPRanges disable -> enable bug |
/test pull-cluster-api-provider-azure-test-v1beta1 |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.10 #3805 +/- ##
================================================
+ Coverage 54.05% 54.10% +0.05%
================================================
Files 186 186
Lines 18837 18847 +10
================================================
+ Hits 10182 10198 +16
+ Misses 8107 8103 -4
+ Partials 548 546 -2
☔ View full report in Codecov by Sentry. |
I opened issue #3810 to track this, so we can remove the |
/lgtm /hold Can we squash commits 2 and 3 together before merge? |
LGTM label has been added. Git tree hash: a8452090f66117ba4effa7ad46b884896945b802
|
8e98a39
to
772247f
Compare
- update AzureSDK once with empty slice and then ignore changes
772247f
to
934e1bd
Compare
Done! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 748458f280f1f16e18600a3db36ceb928054f483
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
//nolint:gocyclo
to theParameters()
function from main since [release-1.10] fix AuthorizedIPRanges disable -> enable bug #3800 was erroring out on go-cyclomexic complexity (A lot of nil checks).Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
TODOs:
Release note: