Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.10] fix AuthorizedIPRanges disable -> enable bug #3805

Merged

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Aug 7, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

authorized IP ranges will be set to []string then to nil upon deletion

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 7, 2023
@nawazkh nawazkh changed the title Fix auth ip reconcile 1.10 fix AuthorizedIPRanges disable -> enable bug Aug 7, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Aug 7, 2023

I will squash the commits once lgtm-ed.

@mboersma
Copy link
Contributor

mboersma commented Aug 7, 2023

/retitle [release-1.10] fix AuthorizedIPRanges disable -> enable bug

@k8s-ci-robot k8s-ci-robot changed the title fix AuthorizedIPRanges disable -> enable bug [release-1.10] fix AuthorizedIPRanges disable -> enable bug Aug 7, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Aug 7, 2023

/test pull-cluster-api-provider-azure-test-v1beta1

@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05% 🎉

Comparison is base (50232eb) 54.05% compared to head (8e98a39) 54.10%.
Report is 1 commits behind head on release-1.10.

❗ Current head 8e98a39 differs from pull request most recent head 934e1bd. Consider uploading reports for the commit 934e1bd to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.10    #3805      +/-   ##
================================================
+ Coverage         54.05%   54.10%   +0.05%     
================================================
  Files               186      186              
  Lines             18837    18847      +10     
================================================
+ Hits              10182    10198      +16     
+ Misses             8107     8103       -4     
+ Partials            548      546       -2     
Files Changed Coverage Δ
azure/services/managedclusters/spec.go 48.71% <100.00%> (+2.72%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor

mboersma commented Aug 8, 2023

Also copies over //nolint:gocyclo to the Parameters() function

I opened issue #3810 to track this, so we can remove the //nolint someday.

@CecileRobertMichon
Copy link
Contributor

/lgtm

/hold

Can we squash commits 2 and 3 together before merge?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a8452090f66117ba4effa7ad46b884896945b802

- update AzureSDK once with empty slice and then ignore changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Aug 9, 2023

Can we squash commits 2 and 3 together before merge?

Done! :)
/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2023
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 748458f280f1f16e18600a3db36ceb928054f483

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2023
@k8s-ci-robot k8s-ci-robot merged commit ab58834 into kubernetes-sigs:release-1.10 Aug 9, 2023
8 checks passed
@nawazkh nawazkh deleted the fix_authIP_reconcile_1.10 branch August 9, 2023 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants