Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.9] add machine pool wait to default e2e parameters #3769

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[release-1.9] add machine pool wait to default e2e parameters #3769

merged 1 commit into from
Jul 31, 2023

Conversation

mboersma
Copy link
Contributor

This is a manual cherry-pick of #3761.

/assign @nojnhuh

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 27, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 27, 2023
@mboersma
Copy link
Contributor Author

/retitle [release-1.9] add machine pool wait to default e2e parameters

@k8s-ci-robot k8s-ci-robot changed the title add machine pool wait to default e2e parameters [release-1.9] add machine pool wait to default e2e parameters Jul 27, 2023
nojnhuh
nojnhuh reviewed Jul 27, 2023
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Matt!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d2b5590ef211297d0707c5e567432405cc70a804

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 27, 2023

That's the first I've tried to approve but I guess it didn't take. I wonder if it's because I'm not a "maintainer" on the release branch? Not a big deal, just trying to get a feel for how that works.

@mboersma
Copy link
Contributor Author

because I'm not a "maintainer" on the release branch?

Yes, I think that's it. You should be able to approve against main though. We could cherry-pick the OWNERS changes if need be.

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (46ad58c) 52.90% compared to head (f807b99) 52.90%.
Report is 3 commits behind head on release-1.9.

Additional details and impacted files 
@@             Coverage Diff              @@
##           release-1.9    #3769   +/-   ##
============================================
  Coverage        52.90%   52.90%           
============================================
  Files              182      182           
  Lines            18250    18250           
============================================
  Hits              9655     9655           
  Misses            8055     8055           
  Partials           540      540

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mboersma
Copy link
Contributor Author

The AKS test failure is addressed by #3772.

@mboersma
Copy link
Contributor Author

/retest

mboersma
mboersma commented Jul 31, 2023
View reviewed changes
Copy link
Contributor Author

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2023
@k8s-ci-robot k8s-ci-robot merged commit a0df012 into kubernetes-sigs:release-1.9 Jul 31, 2023
8 checks passed
@mboersma mboersma deleted the cherry-pick-3761-to-release-1.9 branch July 31, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh left review comments

@devigned devigned Awaiting requested review from devigned

@sonasingh46 sonasingh46 Awaiting requested review from sonasingh46

Assignees

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mboersma @k8s-ci-robot @nojnhuh