Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin k8s e2e version to v1.25.11 #3762

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Pin k8s e2e version to v1.25.11 #3762

merged 1 commit into from
Jul 26, 2023

Conversation

CecileRobertMichon
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon commented Jul 26, 2023 •
edited
Loading

What type of PR is this?

/kind failing-test

What this PR does / why we need it: Trying to see if this fixes #3754

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
mitigates #3754

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 26, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (687e66f) 54.12% compared to head (dfd8de8) 54.12%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3762   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files         187      187           
  Lines       18909    18909           
=======================================
  Hits        10234    10234           
  Misses       8126     8126           
  Partials      549      549

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CecileRobertMichon CecileRobertMichon added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Jul 26, 2023
@CecileRobertMichon
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2023
@CecileRobertMichon CecileRobertMichon changed the title [WIP] Pin k8s e2e version to v1.25.11 Pin k8s e2e version to v1.25.11 Jul 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 26, 2023
@CecileRobertMichon
Copy link
Contributor Author

This looks to be mitigating the issue (e2e test passed on first try), started the optional test to run the dual stack test as well

/assign @nojnhuh

@CecileRobertMichon
Copy link
Contributor Author

/hold

for optional test

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2023
@CecileRobertMichon
Copy link
Contributor Author

/cherry-pick release-1.10
/cherry-pick release-1.9

@k8s-infra-cherrypick-robot
Copy link

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor Author

AKS autoscaler flake

/test pull-cluster-api-provider-azure-e2e-aks

@CecileRobertMichon
Copy link
Contributor Author

@mboersma @nojnhuh thoughts on overriding the aks test here? this is fixing #3754 (or at least getting us unblocked for now) but it can't merge because the aks test is broken in main (tracked by #3763) which is unrelated to this PR (the k8s version change doesn't affect AKS) and @nojnhuh is looking into it separately.

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 26, 2023

+1 to overriding AKS test here

@CecileRobertMichon
Copy link
Contributor Author

/override pull-cluster-api-provider-azure-e2e-aks
/assign @mboersma @nojnhuh

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Overrode contexts on behalf of CecileRobertMichon: pull-cluster-api-provider-azure-e2e-aks

In response to this:

/override pull-cluster-api-provider-azure-e2e-aks
/assign @mboersma @nojnhuh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor Author

/cherry-pick release-1.10
/cherry-pick release-1.9

since this seems to be affecting both

@k8s-infra-cherrypick-robot
Copy link

@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

since this seems to be affecting both

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@CecileRobertMichon
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 26, 2023
@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 26, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 26, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0f0ff07cc2ed08b67ee115d7a5b524f2ca9ca044

@CecileRobertMichon
Copy link
Contributor Author

/override pull-cluster-api-provider-azure-e2e-aks

@k8s-ci-robot
Copy link
Contributor

@CecileRobertMichon: Overrode contexts on behalf of CecileRobertMichon: pull-cluster-api-provider-azure-e2e-aks

In response to this:

/override pull-cluster-api-provider-azure-e2e-aks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mboersma
mboersma approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit baced22 into kubernetes-sigs:main Jul 26, 2023
11 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jul 26, 2023
@k8s-infra-cherrypick-robot
Copy link

@CecileRobertMichon: new pull request created: #3764

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

since this seems to be affecting both

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 26, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@CecileRobertMichon: new pull request created: #3765

In response to this:

/cherry-pick release-1.10
/cherry-pick release-1.9

since this seems to be affecting both

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 26, 2023
Merged
This was referenced Jul 26, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@mboersma mboersma

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.

Calico failing for ipv6 and dual stack clusters with k8s v1.25.12
5 participants
@CecileRobertMichon @k8s-infra-cherrypick-robot @nojnhuh @k8s-ci-robot @mboersma