Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ASO #3723

Merged
merged 2 commits into from
Aug 29, 2023

wire up asogroups

270f646
Select commit
Loading
Failed to load commit list.
Merged

Enable ASO #3723

wire up asogroups
270f646
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 29, 2023 in 0s

55.55% (-0.02%) compared to e812eae

View this Pull Request on Codecov

55.55% (-0.02%) compared to e812eae

Details

Codecov Report

Patch coverage: 31.74% and project coverage change: -0.02% ⚠️

Comparison is base (e812eae) 55.57% compared to head (270f646) 55.55%.
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3723      +/-   ##
==========================================
- Coverage   55.57%   55.55%   -0.02%     
==========================================
  Files         190      190              
  Lines       19523    19531       +8     
==========================================
+ Hits        10850    10851       +1     
- Misses       8064     8070       +6     
- Partials      609      610       +1     
Files Changed Coverage Δ
controllers/azurecluster_controller.go 37.07% <ø> (ø)
controllers/azuremanagedcontrolplane_controller.go 40.66% <ø> (ø)
controllers/helpers.go 56.82% <12.50%> (-0.10%) ⬇️
azure/scope/managedcontrolplane.go 23.88% <14.28%> (+0.01%) ⬆️
controllers/azurecluster_reconciler.go 68.14% <35.71%> (-1.51%) ⬇️
azure/scope/cluster.go 56.48% <40.00%> (-0.33%) ⬇️
controllers/azuremanagedcontrolplane_reconciler.go 37.50% <40.00%> (-0.74%) ⬇️
azure/services/asogroups/groups.go 85.18% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.