Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] renaming cleanup function in ci-build-azure-ccm.sh and ci-build-kubernetes.sh #3692

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3686

/assign CecileRobertMichon

NONE

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 90.76% and project coverage change: +0.09 🎉

Comparison is base (4ad8022) 52.71% compared to head (588a17e) 52.80%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #3692      +/-   ##
===============================================
+ Coverage        52.71%   52.80%   +0.09%     
===============================================
  Files              182      182              
  Lines            18201    18236      +35     
===============================================
+ Hits              9595     9630      +35     
+ Misses            8070     8068       -2     
- Partials           536      538       +2     
Impacted Files Coverage Δ
azure/scope/machinepool.go 32.31% <0.00%> (ø)
azure/services/securitygroups/securitygroups.go 73.56% <85.71%> (+0.96%) ⬆️
azure/scope/cluster.go 57.62% <91.17%> (+1.24%) ⬆️
azure/scope/machine.go 50.71% <100.00%> (-0.41%) ⬇️
azure/services/securitygroups/spec.go 82.19% <100.00%> (+2.82%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7ee52794209f45ed587925b6f0344b530c0a67c2

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2023
@mboersma
Copy link
Contributor

/retest-required

@k8s-ci-robot k8s-ci-robot merged commit 32de2a1 into kubernetes-sigs:release-1.9 Jul 10, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants