Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.9] Delete security rules if removed from spec #3688

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #3591

/assign willie-yao

Delete security rules if removed from spec

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 7, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +0.18 🎉

Comparison is base (9952c7a) 52.63% compared to head (71c7f6b) 52.82%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.9    #3688      +/-   ##
===============================================
+ Coverage        52.63%   52.82%   +0.18%     
===============================================
  Files              182      182              
  Lines            18201    18237      +36     
===============================================
+ Hits              9580     9633      +53     
+ Misses            8083     8066      -17     
  Partials           538      538              
Impacted Files Coverage Δ
azure/services/managedclusters/spec.go 41.77% <25.00%> (+5.14%) ⬆️
azure/scope/cluster.go 57.46% <83.33%> (+1.07%) ⬆️
azure/services/securitygroups/securitygroups.go 73.56% <85.71%> (+0.96%) ⬆️
azure/services/agentpools/spec.go 57.86% <100.00%> (-0.43%) ⬇️
azure/services/securitygroups/spec.go 82.19% <100.00%> (+2.82%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mboersma
Copy link
Contributor

mboersma commented Jul 7, 2023

It looks like we have a consistent failure with these two jobs on the release-1.9 branch.

@willie-yao
Copy link
Contributor

@mboersma Is this related to test infra moving to EKS? Seems similar to the previous failures with tests being killed.

@mboersma
Copy link
Contributor

mboersma commented Jul 7, 2023

@willie-yao I think you're right. I opened kubernetes/test-infra#30028 which hopefully will fix it.

@mboersma
Copy link
Contributor

mboersma commented Jul 7, 2023

/retest

Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6acd05dd9f72eb95f0998972c55411c8f367d4c8

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit eae5f74 into kubernetes-sigs:release-1.9 Jul 7, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants