-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.9] Delete security rules if removed from spec #3688
[release-1.9] Delete security rules if removed from spec #3688
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #3688 +/- ##
===============================================
+ Coverage 52.63% 52.82% +0.18%
===============================================
Files 182 182
Lines 18201 18237 +36
===============================================
+ Hits 9580 9633 +53
+ Misses 8083 8066 -17
Partials 538 538
☔ View full report in Codecov by Sentry. |
It looks like we have a consistent failure with these two jobs on the release-1.9 branch. |
@mboersma Is this related to test infra moving to EKS? Seems similar to the previous failures with tests being killed. |
@willie-yao I think you're right. I opened kubernetes/test-infra#30028 which hopefully will fix it. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 6acd05dd9f72eb95f0998972c55411c8f367d4c8
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #3591
/assign willie-yao