Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tiltfile to support azure cni dev #3609

Merged
merged 1 commit into from
Jul 11, 2023
Merged

update tiltfile to support azure cni dev #3609

merged 1 commit into from
Jul 11, 2023

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jun 7, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:

  • Updates Tiltfile for local development of workload cluster using Azure CNI v1

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #3610

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. labels Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 7, 2023
@nawazkh
Copy link
Member Author

nawazkh commented Jun 7, 2023

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2023
@nawazkh nawazkh added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jun 7, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.73 ⚠️

Comparison is base (fa8ed47) 53.96% compared to head (fac2f03) 53.24%.

❗ Current head fac2f03 differs from pull request most recent head 0eca74b. Consider uploading reports for the commit 0eca74b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3609      +/-   ##
==========================================
- Coverage   53.96%   53.24%   -0.73%     
==========================================
  Files         186      185       -1     
  Lines       18819    18432     -387     
==========================================
- Hits        10156     9814     -342     
+ Misses       8118     8076      -42     
+ Partials      545      542       -3

see 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@nawazkh nawazkh changed the title [WIP] update tiltfile to support azure cni dev update tiltfile to support azure cni dev Jun 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 8, 2023
@nawazkh nawazkh force-pushed the azure-cni-tilt branch 3 times, most recently from 3828d0a to 4c9f49e Compare June 14, 2023 23:52
@nawazkh
Copy link
Member Author

nawazkh commented Jun 14, 2023

Was able to bring up workload cluster using Azure cni v1 via Tilt.
Screenshot 2023-06-14 at 4 50 03 PM

Screenshot 2023-06-14 at 4 50 12 PM

@nawazkh
Copy link
Member Author

nawazkh commented Jun 14, 2023

/cc @CecileRobertMichon

CecileRobertMichon
CecileRobertMichon reviewed Jun 19, 2023
View reviewed changes
Tiltfile Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 23, 2023
@CecileRobertMichon
Copy link
Contributor

@nawazkh I tried deploying a cluster with the "azure-cni-v1" flavor on tilt, everything came up successfully and nodes are Ready but when I list the pods I can see the coredns pods aren't ready:

k get pods -A                                          
NAMESPACE     NAME                                                             READY   STATUS    RESTARTS      AGE
kube-system   azure-cni-549kt                                                  1/1     Running   0             5m5s
kube-system   azure-cni-gbxld                                                  1/1     Running   0             4m25s
kube-system   azure-cni-zlqnx                                                  1/1     Running   0             6m34s
kube-system   cloud-controller-manager-749955c9db-fgkmw                        1/1     Running   0             6m35s
kube-system   cloud-node-manager-lcmgk                                         1/1     Running   0             6m35s
kube-system   cloud-node-manager-qkc62                                         1/1     Running   0             5m5s
kube-system   cloud-node-manager-xdb47                                         1/1     Running   0             4m25s
kube-system   coredns-787d4945fb-4cx72                                         0/1     Running   3 (51s ago)   7m11s
kube-system   coredns-787d4945fb-g88bt                                         0/1     Running   3 (51s ago)   7m11s
kube-system   etcd-azure-cni-v1-14036-control-plane-bkg82                      1/1     Running   0             7m10s
kube-system   kube-apiserver-azure-cni-v1-14036-control-plane-bkg82            1/1     Running   0             7m11s
kube-system   kube-controller-manager-azure-cni-v1-14036-control-plane-bkg82   1/1     Running   0             7m10s
kube-system   kube-proxy-66ps8                                                 1/1     Running   0             5m5s
kube-system   kube-proxy-bjkfz                                                 1/1     Running   0             7m11s
kube-system   kube-proxy-z28mj                                                 1/1     Running   0             4m25s
kube-system   kube-scheduler-azure-cni-v1-14036-control-plane-bkg82            1/1     Running   0             7m10s

Looking at the pod describe I see

Warning Unhealthy 54s (x44 over 5m57s) kubelet Readiness probe failed: Get "http://10.0.0.45:8181/ready": dial tcp 10.0.0.45:8181: connect: connection refused

@CecileRobertMichon
Copy link
Contributor

Was able to get this working with k8s v1.27.2. The above repro uses k8s v1.26.1.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 8, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 10, 2023
@nawazkh
update Tiltfile to use azure-cni-v1 manifest
0eca74b 
- also update min K8s versions being used
- specify CIDR for cloud-controller-manager
- fetch CIDR values from the kind: Cluster
@nawazkh
Copy link
Member Author

nawazkh commented Jul 11, 2023

Was able to get this working with k8s v1.27.2. The above repro uses k8s v1.26.1.

I dont see this behavior using K8s v1.26.6

Every 1.0s: kubectl get pods -A -o wide                                                                                                                                                                           MacBook-Pro-2.local: Tue Jul 11 12:45:58 2023

NAMESPACE     NAME                                                            READY   STATUS    RESTARTS   AGE   IP           NODE                                    NOMINATED NODE   READINESS GATES
kube-system   azure-cni-h72bl                                                 1/1     Running   0          13m   10.1.0.114   azure-cni-v1-3096-md-0-cxwvv            <none>           <none>
kube-system   azure-cni-ndg5n                                                 1/1     Running   0          15m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   azure-cni-qbnwt                                                 1/1     Running   0          13m   10.1.0.4     azure-cni-v1-3096-md-0-4rq66            <none>           <none>
kube-system   cloud-controller-manager-5757c65db4-5dmpt                       1/1     Running   0          15m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   cloud-node-manager-6ptkl                                        1/1     Running   0          15m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   cloud-node-manager-86f9x                                        1/1     Running   0          13m   10.1.0.4     azure-cni-v1-3096-md-0-4rq66            <none>           <none>
kube-system   cloud-node-manager-9bqkw                                        1/1     Running   0          13m   10.1.0.114   azure-cni-v1-3096-md-0-cxwvv            <none>           <none>
kube-system   coredns-787d4945fb-r9w22                                        1/1     Running   0          16m   10.0.0.33    azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   coredns-787d4945fb-rnrq6                                        1/1     Running   0          16m   10.0.0.7     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   etcd-azure-cni-v1-3096-control-plane-tgmkb                      1/1     Running   0          16m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   kube-apiserver-azure-cni-v1-3096-control-plane-tgmkb            1/1     Running   0          16m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   kube-controller-manager-azure-cni-v1-3096-control-plane-tgmkb   1/1     Running   0          16m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   kube-proxy-7cz7w                                                1/1     Running   0          13m   10.1.0.4     azure-cni-v1-3096-md-0-4rq66            <none>           <none>
kube-system   kube-proxy-qcllx                                                1/1     Running   0          16m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>
kube-system   kube-proxy-t8bxc                                                1/1     Running   0          13m   10.1.0.114   azure-cni-v1-3096-md-0-cxwvv            <none>           <none>
kube-system   kube-scheduler-azure-cni-v1-3096-control-plane-tgmkb            1/1     Running   0          16m   10.0.0.4     azure-cni-v1-3096-control-plane-tgmkb   <none>           <none>


❯ k version -o yaml
clientVersion:
  buildDate: "2023-05-17T14:20:07Z"
  compiler: gc
  gitCommit: 7f6f68fdabc4df88cfea2dcf9a19b2b830f1e647
  gitTreeState: clean
  gitVersion: v1.27.2
  goVersion: go1.20.4
  major: "1"
  minor: "27"
  platform: darwin/arm64
kustomizeVersion: v5.0.1
serverVersion:
  buildDate: "2023-06-14T09:49:08Z"
  compiler: gc
  gitCommit: 11902a838028edef305dfe2f96be929bc4d114d8
  gitTreeState: clean
  gitVersion: v1.26.6
  goVersion: go1.19.10
  major: "1"
  minor: "26"
  platform: linux/amd64

CecileRobertMichon
CecileRobertMichon reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 779c084c95f8d092ec67192f84dfdd202a863d56

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7f52558 into kubernetes-sigs:main Jul 11, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.10 milestone Jul 11, 2023
@nawazkh nawazkh mentioned this pull request Jul 17, 2023
Closed
2 tasks
@nawazkh nawazkh deleted the azure-cni-tilt branch August 31, 2023 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@willie-yao willie-yao Awaiting requested review from willie-yao

Assignees

@CecileRobertMichon CecileRobertMichon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Archived in project
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
3 participants
@nawazkh @CecileRobertMichon @k8s-ci-robot