Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ClusterClass Support for Managed Clusters #3197

Closed
wants to merge 5 commits into from

Conversation

willie-yao
Copy link
Contributor

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds ClusterClass support for managed clusters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #2684

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Add ClusterClass support for managed clusters

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 22, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 22, 2023
@willie-yao willie-yao changed the title Add ClusterClass Support for Managed Clusters WIP: Add ClusterClass Support for Managed Clusters Feb 22, 2023
@willie-yao willie-yao force-pushed the clusterclass-aks branch 4 times, most recently from 907f361 to 3612527 Compare February 28, 2023 21:00
test/e2e/azure_test.go Outdated Show resolved Hide resolved
@willie-yao willie-yao force-pushed the clusterclass-aks branch 2 times, most recently from eb7d325 to 0ee5537 Compare March 3, 2023 00:32
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@willie-yao willie-yao force-pushed the clusterclass-aks branch 3 times, most recently from 4d54600 to 3e04ef7 Compare March 3, 2023 18:55
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 16, 2023
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 23, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mboersma for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Attention: 133 lines in your changes are missing coverage. Please review.

Comparison is base (b4221b5) 57.83% compared to head (fd1b69a) 56.66%.
Report is 6 commits behind head on main.

❗ Current head fd1b69a differs from pull request most recent head 7fb9fc5. Consider uploading reports for the commit 7fb9fc5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3197      +/-   ##
==========================================
- Coverage   57.83%   56.66%   -1.18%     
==========================================
  Files         187      195       +8     
  Lines       19197    19429     +232     
==========================================
- Hits        11103    11009      -94     
- Misses       7466     7788     +322     
- Partials      628      632       +4     
Files Coverage Δ
api/v1beta1/azuremanagedclustertemplate_types.go 100.00% <100.00%> (ø)
api/v1beta1/azuremanagedcontrolplane_types.go 20.00% <ø> (ø)
.../v1beta1/azuremanagedcontrolplanetemplate_types.go 100.00% <100.00%> (ø)
...i/v1beta1/azuremanagedmachinepooltemplate_types.go 100.00% <100.00%> (ø)
api/v1beta1/types_template.go 89.47% <ø> (ø)
api/v1beta1/azuremanagedcontrolplane_webhook.go 89.23% <96.00%> (-0.45%) ⬇️
controllers/helpers.go 57.06% <20.00%> (-0.33%) ⬇️
api/v1beta1/azuremanagedcontrolplane_default.go 92.85% <16.66%> (-4.32%) ⬇️
...1beta1/azuremanagedcontrolplanetemplate_default.go 81.72% <81.72%> (ø)
api/v1beta1/azuremanagedclustertemplate_webhook.go 0.00% <0.00%> (ø)
... and 2 more

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@willie-yao
Copy link
Contributor Author

/retest

@willie-yao willie-yao force-pushed the clusterclass-aks branch 6 times, most recently from dada439 to 0d3104f Compare October 3, 2023 00:14
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@willie-yao
Copy link
Contributor Author

/retest

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

1 similar comment
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-provider-azure-e2e-optional

@willie-yao willie-yao changed the title WIP: Add ClusterClass Support for Managed Clusters Add ClusterClass Support for Managed Clusters Oct 12, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 12, 2023
@willie-yao willie-yao force-pushed the clusterclass-aks branch 4 times, most recently from f1600b1 to 005247a Compare October 18, 2023 21:00
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 18, 2023

@willie-yao: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e 3b11a46 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-e2e-aks 3b11a46 link true /test pull-cluster-api-provider-azure-e2e-aks
pull-cluster-api-provider-azure-capi-e2e 3b11a46 link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-conformance 3b11a46 link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts 3b11a46 link false /test pull-cluster-api-provider-azure-windows-containerd-upstream-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts 3b11a46 link false /test pull-cluster-api-provider-azure-conformance-ipv6-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts 3b11a46 link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-test 3b11a46 link true /test pull-cluster-api-provider-azure-test
pull-cluster-api-provider-azure-apiversion-upgrade 3b11a46 link false /test pull-cluster-api-provider-azure-apiversion-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@willie-yao
Copy link
Contributor Author

/close
in favor of #4155 for more visibility and split commits

@k8s-ci-robot
Copy link
Contributor

@willie-yao: Closed this PR.

In response to this:

/close
in favor of #4155 for more visibility and split commits

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add support for ClusterClass and managed clusters
3 participants