Skip to content

Update golangci-lint and add golangci-lint GitHub workflow #42

Update golangci-lint and add golangci-lint GitHub workflow

Update golangci-lint and add golangci-lint GitHub workflow #42

Triggered via pull request October 3, 2024 19:48
Status Failure
Total duration 3m 51s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

20 errors
lint (test): test/e2e/helm.go#L42
G204: Subprocess launched with variable (gosec)
lint (test): test/e2e/helm.go#L72
G204: Subprocess launched with variable (gosec)
lint (test): test/e2e/kubernetes/windows/windows.go#L53
unused-parameter: parameter 'testImage' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/kubernetes/networkpolicy/networkpolicy.go#L113
unused-parameter: parameter 'nwpolicyName' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/helpers.go#L82
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/helpers.go#L152
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/helpers.go#L247
unused-parameter: parameter 'opts' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/aks_public_ip_prefix.go#L81
unused-parameter: parameter 'g' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/azure_logcollector.go#L136
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/cni.go#L55
unused-parameter: parameter 'cidrBlocks' seems to be unused, consider removing or renaming it as _ (revive)
lint: internal/test/record/logger.go#L186
emptyStringTest: replace `len(l.prefix) > 0` with `l.prefix != ""` (gocritic)
lint: api/v1beta1/azurecluster_validation.go#L512
emptyStringTest: replace `len(privateDNSZoneName) > 0` with `privateDNSZoneName != ""` (gocritic)
lint: azure/converters/resourcehealth.go#L48
emptyStringTest: replace `len(word) > 0` with `word != ""` (gocritic)
lint: azure/scope/cluster.go#L724
emptyStringTest: replace `len(s.AzureCluster.Spec.NetworkSpec.PrivateDNSZoneName) > 0` with `s.AzureCluster.Spec.NetworkSpec.PrivateDNSZoneName != ""` (gocritic)
lint: internal/test/env/env.go#L136
G304: Potential file inclusion via variable (gosec)
lint: test/e2e/helm.go#L42
G204: Subprocess launched with variable (gosec)
lint: test/e2e/helm.go#L72
G204: Subprocess launched with variable (gosec)
lint: azure/services/subnets/spec.go#L101
Consider pre-allocating `serviceEndpoints` (prealloc)
lint: controllers/resource_reconciler.go#L66
Consider pre-allocating `newResourceStatuses` (prealloc)
lint: test/e2e/kubernetes/windows/windows.go#L53
unused-parameter: parameter 'testImage' seems to be unused, consider removing or renaming it as _ (revive)