Skip to content

Update golangci-lint and add golangci-lint GitHub workflow #40

Update golangci-lint and add golangci-lint GitHub workflow

Update golangci-lint and add golangci-lint GitHub workflow #40

Triggered via pull request October 3, 2024 19:17
Status Failure
Total duration 2m 57s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

20 errors
lint (test): test/e2e/helm.go#L42
G204: Subprocess launched with variable (gosec)
lint (test): test/e2e/helm.go#L72
G204: Subprocess launched with variable (gosec)
lint (test): test/e2e/kubernetes/windows/windows.go#L53
unused-parameter: parameter 'testImage' seems to be unused, consider removing or renaming it as _ (revive)
lint (test): test/e2e/kubernetes/windows/windows.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/storageclass/storageclass.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/deployment/deployment.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/pod/pod.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/node/node.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/namespace/namespace.go#L20
package-comments: should have a package comment (revive)
lint (test): test/e2e/kubernetes/pvc/pvc.go#L20
package-comments: should have a package comment (revive)
lint: internal/test/record/logger.go#L186
emptyStringTest: replace `len(l.prefix) > 0` with `l.prefix != ""` (gocritic)
lint: azure/converters/resourcehealth.go#L47
emptyStringTest: replace `len(word) > 0` with `word != ""` (gocritic)
lint: api/v1beta1/azurecluster_validation.go#L511
emptyStringTest: replace `len(privateDNSZoneName) > 0` with `privateDNSZoneName != ""` (gocritic)
lint: azure/scope/cluster.go#L723
emptyStringTest: replace `len(s.AzureCluster.Spec.NetworkSpec.PrivateDNSZoneName) > 0` with `s.AzureCluster.Spec.NetworkSpec.PrivateDNSZoneName != ""` (gocritic)
lint: internal/test/env/env.go#L135
G304: Potential file inclusion via variable (gosec)
lint: test/e2e/helm.go#L42
G204: Subprocess launched with variable (gosec)
lint: test/e2e/helm.go#L72
G204: Subprocess launched with variable (gosec)
lint: azure/services/subnets/spec.go#L100
Consider pre-allocating `serviceEndpoints` (prealloc)
lint: controllers/resource_reconciler.go#L65
Consider pre-allocating `newResourceStatuses` (prealloc)
lint: exp/doc.go#L17
package-comments: should have a package comment (revive)