Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use force unmount and explicitly unmount bad mount points #183

Draft
wants to merge 1 commit into
base: development
Choose a base branch
from

Commits on Oct 16, 2024

  1. Use force unmount and explicitly unmount bad mount points

    There have been cases where the logic to cleanup a mount point
    has caused the driver to get into a bad state. This is most
    obvious when a subdirectory is mounted to a volume and a parent
    directory of that subdirectory is deleted. The Lustre driver
    doesn't handle that case in the way that Kubernetes expects
    and returns invalid data. To avoid this scenario causing our
    driver to get into a bad state, leak mount points, etc, we
    must explicitly check that we can read the necessary information
    about the mount point, and if not, explicitly unmount that
    mount point before allowing Kubernetes to clean up the directory.
    To ensure that we don't end up in a bad state, this change
    enables force unmounting as well. The force unmount will only
    occur after a timeout has expired, since force unmounts can
    cause issues with the Lustre driver. However, in this case, it
    is better if we are in a bad enough situation to be able to
    eventually return to a good state rather than require manual
    intervention.
    dabradley committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9297cb4 View commit details
    Browse the repository at this point in the history