Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the documented .Capabilities.KubeVersion.Version built-in value in the hpa template #3766

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

prasadkatti
Copy link
Contributor

Issue

.Capabilities.KubeVersion.GitVersion is undocumented in Helm v3 - https://helm.sh/docs/chart_template_guide/builtin_objects/

Description

The value .Capabilities.KubeVersion.GitVersion is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects

It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/

We should stick to the officially documented values.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects

It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/

We should stick to the officially documented values.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @prasadkatti. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2024
@shraddhabang
Copy link
Collaborator

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2024
@shraddhabang
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 25, 2024
@wweiwei-li
Copy link
Collaborator

/lgtm

@shraddhabang
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: prasadkatti, shraddhabang
Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shraddhabang shraddhabang merged commit a022c82 into kubernetes-sigs:main Sep 24, 2024
4 of 5 checks passed
zac-nixon pushed a commit to zac-nixon/aws-load-balancer-controller that referenced this pull request Sep 24, 2024
…ate (kubernetes-sigs#3766)

The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects

It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/

We should stick to the officially documented values.
zac-nixon pushed a commit to zac-nixon/aws-load-balancer-controller that referenced this pull request Oct 1, 2024
…ate (kubernetes-sigs#3766)

The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects

It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/

We should stick to the officially documented values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants