-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the documented .Capabilities.KubeVersion.Version built-in value in the hpa template #3766
Conversation
The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/ We should stick to the officially documented values.
Hi @prasadkatti. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/lgtm |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: prasadkatti, shraddhabang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ate (kubernetes-sigs#3766) The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/ We should stick to the officially documented values.
…ate (kubernetes-sigs#3766) The value `.Capabilities.KubeVersion.GitVersion` is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objects It seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/ We should stick to the officially documented values.
Issue
.Capabilities.KubeVersion.GitVersion
is undocumented in Helm v3 - https://helm.sh/docs/chart_template_guide/builtin_objects/Description
The value
.Capabilities.KubeVersion.GitVersion
is documented in Helm v2 docs - https://v2.helm.sh/docs/chart_template_guide/#built-in-objectsIt seems to also work with Helm v3, but it is not documented in the docs - https://helm.sh/docs/chart_template_guide/builtin_objects/
We should stick to the officially documented values.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯