-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow setting of hostNetwork for the node ds #1410
base: master
Are you sure you want to change the base?
Conversation
The committers listed above are authorized under a signed CLA. |
Welcome @nwsparks! |
Hi @nwsparks. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nwsparks The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Referring to my comment here: my understanding is that if |
Is this a bug fix or adding new feature?
feature
What is this PR about? / Why do we need it?
allows configuration of the hotstNetwork setting for the node daemonset. This behavior is desired, but can be problematic for existing deployments. Some background:
#1179
#1127
Providing the option is beneficial for new installs, or people willing to resolve the mount problems when changing modes.