Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Initialize runtimes before the manager starts #2306

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Oct 24, 2024

What this PR does / why we need it:
I fixed the bug that the runtime initialization is performed after the manager starts.

NAME                                    READY   STATUS             RESTARTS      AGE
training-operator-v2-6446df9d8f-dtcmz   0/1     CrashLoopBackOff   6 (19s ago)   6m31s
{"level":"error","ts":"2024-10-24T19:43:24.046731262Z","logger":"setup","caller":"training-operator.v2alpha1/main.go:159","msg":"Could not initialize runtimes","error":"initializing runtime \"TrainingRuntime.kubeflow.org\": setting index on TrainingRuntime for TrainJob: informer has already started","stacktrace":"main.setupControllers\n\t/workspace/cmd/training-operator.v2alpha1/main.go:159"}

The manager starting indicates that informers (including indexers) cache server starts. But, the current implementation tries to add informer parameters to the already launched informer server.

After this implementations, the manager successful to start in the following:

NAME                                    READY   STATUS    RESTARTS   AGE
training-operator-v2-78f898588f-tlgjf   1/1     Running   0          8m16s

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @tenzen-y
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

/hold for CI

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11506422392

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11506111627: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

@tenzen-y
Copy link
Member Author

/hold cancel

@google-oss-prow google-oss-prow bot merged commit 9ed4112 into kubeflow:master Oct 24, 2024
41 checks passed
@tenzen-y tenzen-y deleted the fix-v2-startup-error branch October 24, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants