Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] Training Client Conditions related unit tests #2253

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Bobbins228
Copy link
Contributor

What this PR does / why we need it:
The following unit tests are added with this PR.

  • get_job_conditions
  • is_job_created
  • is_job_running
  • is_job_restarting
  • is_job_failed
  • is_job_succeeded

You can verify each unit test with the following command substituting <test_name> for one of the tests above.

pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k <test_name>

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Related to #2161

Checklist:

  • Docs included if any changes are user facing

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jinchihe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobbins228
Copy link
Contributor Author

Let me know if this is too large for 1 PR.
Thought I would group them all together as they are very similar tests.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10789407864

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 10780524643: 0.0%
Covered Lines: 66
Relevant Lines: 66

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants