Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KEP-2170: Bind repository into the build environment instead of filecopy #2222

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Aug 15, 2024

What this PR does / why we need it:
I replaced the approach of copying repository files in the container image build env.
We can avoid the copy of files by using --mont=bind option.

Additionally, I resolved https://docs.docker.com/reference/build-checks/from-as-casing/ warning.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Part-of #2206
Follow-up-of: #2221

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10408130697

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.06%) to 33.41%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
pkg/controller.v1/mpi/mpijob_controller.go 6 80.48%
Totals Coverage Status
Change from base Build 10408045115: -0.06%
Covered Lines: 3942
Relevant Lines: 11799

💛 - Coveralls

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tenzen-y !
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3f9b0a4 into kubeflow:master Aug 15, 2024
39 checks passed
@tenzen-y tenzen-y deleted the avoid-copy-repository branch August 15, 2024 18:29
@tenzen-y tenzen-y linked an issue Aug 16, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KEP-2170: Add APIs for TrainJob and TrainingRuntime
3 participants