-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] test: add unit test for get_job method of the training_client #2205
Conversation
Pull Request Test Coverage Report for Build 10698571584Details
💛 - Coveralls |
12d5460
to
acbaf5e
Compare
@Bobbins228 Please rebase this PR |
acbaf5e
to
2e2e138
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this @Bobbins228!
I left a few comments.
Signed-off-by: Bobbins228 <[email protected]>
2e2e138
to
08ad249
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update @Bobbins228!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @andreyvelich I can take a look at some of the other UTs later in the week if we still have some that need to be written |
That sound great, we still have a few of them in this issue: #2161 |
What this PR does / why we need it:
add unit test for get_job method of the training_client
To verify run:
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Ref: #2161
Checklist: