Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] test: add unit test for get_job method of the training_client #2205

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Bobbins228
Copy link
Contributor

What this PR does / why we need it:
add unit test for get_job method of the training_client

To verify run:

pytest -v sdk/python/kubeflow/training/api/training_client_test.py -k test_get_job

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Ref: #2161
Checklist:

  • Docs included if any changes are user facing

@Bobbins228 Bobbins228 changed the title test: add unit test for get_job method of the training_client [SDK] test: add unit test for get_job method of the training_client Aug 14, 2024
@coveralls
Copy link

coveralls commented Aug 14, 2024

Pull Request Test Coverage Report for Build 10698571584

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 31.753%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
pkg/controller.v1/mpi/mpijob_controller.go 6 80.67%
Totals Coverage Status
Change from base Build 10673563990: -0.04%
Covered Lines: 3944
Relevant Lines: 12421

💛 - Coveralls

@andreyvelich
Copy link
Member

@Bobbins228 Please rebase this PR

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @Bobbins228!
I left a few comments.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update @Bobbins228!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 00eef58 into kubeflow:master Sep 4, 2024
39 checks passed
@Bobbins228
Copy link
Contributor Author

Thanks @andreyvelich I can take a look at some of the other UTs later in the week if we still have some that need to be written

@andreyvelich
Copy link
Member

That sound great, we still have a few of them in this issue: #2161
Thanks for your contributions @Bobbins228!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants