Migrate to controller-runtime logger in mpi job controller #2177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Test Coverage Report for Build 10006593907Details
💛 - Coveralls |
champon1020
force-pushed
the
patch-issue-2048
branch
2 times, most recently
from
89ae18a
to
00b6c51
Compare
Signed-off-by: champon1020 <[email protected]>
champon1020
force-pushed
the
patch-issue-2048
branch
from
00b6c51
to
bbc9872
Compare
champon1020
commented
Jul 19, 2024
| @@ -74,7 +72,7 @@ func NewReconciler(mgr manager.Manager, gangSchedulingSetupFunc common.GangSched | |||
| Scheme: mgr.GetScheme(), | |||
| recorder: mgr.GetEventRecorderFor(controllerName), | |||
| apiReader: mgr.GetAPIReader(), | |||
| Log: log.Log, | |||
| Log: log.Log.WithName(controllerName), | |||
There was a problem hiding this comment.
note: attach controllerName as the logger name
| }() | ||
|
|
||
| mpiJob = mpiJob.DeepCopy() | ||
| mpiJob.Status = *jobStatus.DeepCopy() | ||
|
|
||
| result := jc.Status().Update(context.Background(), mpiJob) | ||
|
|
||
| if result != nil { |
There was a problem hiding this comment.
note: I think this if statement may be no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
As mentioned at #2048, we should migrate to Controller Runtime Logger while there are some types of logger currently. First, I modified it only in the MPI Job Controller since I want to determine a course of action. (I'm going to implement the remaining modifications in the next PR)
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #2048
Checklist: