Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: volcano podgroup should has a non-empty queue name #1977

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

lowang-bh
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1967

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7444891160

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 42.931%

Totals Coverage Status
Change from base Build 7423814404: 0.1%
Covered Lines: 3759
Relevant Lines: 8756

💛 - Coveralls

@johnugeorge
Copy link
Member

Thanks @lowang-bh
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, lowang-bh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 3d74a58 into kubeflow:master Jan 10, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is it better to set default queue to default instead of empty string when syncing jobs
3 participants